Reparent AmbiguousOutputError onto AttributeError #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just conceptually errors being raised from `__getattr__` ought to be this way anyhow, not `ValueError`. But more importantly, raising a `ValueError` instead of an `AttributeError` meant that the builtin `hasattr` method couldn't properly return `False` when the lookup failed due to not having an unambiguous `.channel` attribute to which to delegate the lookup. Signed-off-by: liamhuber <[email protected]>
|
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Pull Request Test Coverage Report for Build 13357835816Details
💛 - Coveralls |
Signed-off-by: liamhuber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just conceptually errors being raised from
__getattr__ought to be this way anyhow, notValueError. But more importantly, raising aValueErrorinstead of anAttributeErrormeant that the builtinhasattrmethod couldn't properly returnFalsewhen the lookup failed due to not having an unambiguous.channelattribute to which to delegate the lookup.Since we redirect
__getitem__to__getattr__, maybeAmbiguousOutputErrorshould have dual inheritance withAttributeErrorandKeyError. However, this PR is really to address the key problem thathasattris failing. Since I didn't have to touch the rest of the test suite, it seems to have accomplished it without any other side effects. I'd like to delay further modifications until a clear need appears.